[vlc-devel] [PATCH 17/17] video_output: restart display after filter change

[Alexandre Janniaux]

On Tue, Nov 24, 2020 at 05:37:38PM +0200, Rémi Denis-Courmont wrote:
> Le lundi 23 novembre 2020, 14:21:29 EET Steve Lhomme a écrit :
> > On 2020-11-22 10:22, Rémi Denis-Courmont wrote:
> > > Le perjantaina 20. marraskuuta 2020, 16.45.07 EET Steve Lhomme a écrit :
> > >> This is done in the vout thread loop, immediately after the filter output
> > >> change is detected, before processing pictures coming out of the filters.
> > >> The filters are untouched (not flushed).
> > >>
> > >> The new display module is created with the format coming out of the last
> > >> filter.
> > >
> > > As you have pointed out yourself, this causes glitches if the windowing
> > > system is not capable of retaining the window content while restarting
> > > the display. AFAICT; without this patch, it works just fine: the
> > > conversion filter chain is adjusted and the display has nothing to worry
> > > about.
> >
> > It doesn't work *just fine*, an extra filter is added to match the
> > original display format.
>
> Itss removing the old conversion and adding a new conversion. That's working
> fine and as intended.

Wouldn't it conflict with the «best probe» model, in particular if
the new format is compatible with passthrough display, like you
mentioned in previous threads?

Regards,
--
Alexandre Janniaux
Videolabs