[vlc-devel] [PATCH 6/7] extras: export a build system compiler in the macOS script to fix nettle compilation with latest Xcode

[naich64]

> Am 29.11.2020 um 20:12 schrieb Felix Paul Kühne <fkuehne at videolan.org>:
> 
> From: Felix Paul Kühne <felix at feepk.net>
> 
> ---
> extras/package/macosx/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/extras/package/macosx/build.sh b/extras/package/macosx/build.sh
> index 44b16ce59b..b121864a25 100755
> --- a/extras/package/macosx/build.sh
> +++ b/extras/package/macosx/build.sh
> @@ -145,6 +145,7 @@ fi
> export AR="`xcrun --find ar`"
> export AS="`xcrun --find as`"
> export CC="`xcrun --find clang`"
> +export CC_FOR_BUILD="`xcrun --find clang` -Wno-error=implicit-function-declaration"

implicit-function-declaration sounds like a rather serious problem we should fix in the actual code, otherwise we might keep bugs here. So I would rather prefer to fix this one instance of nettle directly (maybe with a contrib patch).
This line seems to be too broad and could hide other problems in different contribs as well.

> export CXX="`xcrun --find clang++`"
> export LD="`xcrun --find ld`"
> export NM="`xcrun --find nm`"
> @@ -155,7 +156,6 @@ export STRIP="`xcrun --find strip`"
> export SDKROOT
> export PATH="${vlcroot}/extras/tools/build/bin:${vlcroot}/contrib/${TRIPLET}/bin:$python3Path:${VLC_PATH}:/bin:/sbin:/usr/bin:/usr/sbin"
> 
> -
> # Select avcodec flavor to compile contribs with
> export USE_FFMPEG=1
> 
> -- 
> 2.24.3 (Apple Git-128)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel