[vlc-devel] [PATCH 6/7] extras: export a build system compiler in the macOS script to fix nettle compilation with latest Xcode

[Felix Paul Kühne]

Hi David,

Thanks for the quick review!

> Am 30.11.2020 um 08:49 schrieb naich64 <david.fuhrmann at gmail.com>:
> 
> 
> 
>> Am 29.11.2020 um 20:12 schrieb Felix Paul Kühne <fkuehne at videolan.org>:
>> 
>> From: Felix Paul Kühne <felix at feepk.net>
>> 
>> ---
>> extras/package/macosx/build.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/extras/package/macosx/build.sh b/extras/package/macosx/build.sh
>> index 44b16ce59b..b121864a25 100755
>> --- a/extras/package/macosx/build.sh
>> +++ b/extras/package/macosx/build.sh
>> @@ -145,6 +145,7 @@ fi
>> export AR="`xcrun --find ar`"
>> export AS="`xcrun --find as`"
>> export CC="`xcrun --find clang`"
>> +export CC_FOR_BUILD="`xcrun --find clang` -Wno-error=implicit-function-declaration"
> 
> implicit-function-declaration sounds like a rather serious problem we should fix in the actual code, otherwise we might keep bugs here. So I would rather prefer to fix this one instance of nettle directly (maybe with a contrib patch).
> This line seems to be too broad and could hide other problems in different contribs as well.

I need to add a comment to the script here. CC_FOR_BUILD is used exclusively by nettle and also only to compile its own build system used to compile the resulting library. The warning needs to be silenced to work-around nettle’s broken configure detection for the system CC compiler. This compiler option is never applied on any code distributed with VLC.

Best regards,

Felix