[vlc-devel] [PATCH 4/5] stream_ReadLine: support arbitrary length limit

Pierre Ynard linkfanel at yahoo.fr
Mon Sep 7 18:27:27 CEST 2020


> I already explained why we need a limit and I stopped reading at the
> FUD accusations.

You advanced several alternatives explanations; I rebutted them all and
none of them stands.

- First you said it was to prevent memory starvation and integer
  overflows. I explained the math showing it obviously didn't stand.

- Then you implied lua playlist scripts should really use XML/JSON
  parsers. I gave it a fair try but showed why it didn't work.

- Then you changed your version and said it was to protect URL and
  metadata consumers down the line. I explained why it didn't stand.

At every point I tried to engage constructively with you. I listened to
what you said. I offered you several possible and alternative solutions:
you refused to discuss them with me. You never actually offered any
solution yourself: I was the one who explored the XML/JSON parser
approach and laid out its implications and issues. Nevertheless, despite
your lack of feedback, I went ahead and offered several alternatives
patches; I refactored the code and carefully tested the changes: you
shot them all down indiscriminately. I even fixed your own glaring bugs
in that code.

I don't know whether you really did or didn't read what I wrote. The
result is the same: when you say that, you have nothing to reply to my
technical arguments; as if you're not interested in talking about that.
So let's keep talking about it instead.

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."


More information about the vlc-devel mailing list