[vlc-devel] [PATCH 4/5] stream_ReadLine: support arbitrary length limit

Rémi Denis-Courmont remi at remlab.net
Mon Sep 7 18:42:19 CEST 2020


Le maanantaina 7. syyskuuta 2020, 19.27.27 EEST Pierre Ynard via vlc-devel a 
écrit :
> You advanced several alternatives explanations; I rebutted them all and
> none of them stands.
> 
> - First you said it was to prevent memory starvation and integer
>   overflows. I explained the math showing it obviously didn't stand.

No. From the beginning I pointed out that the memory starvation problem came 
from users storing many lines simultaneously. I can do multiplications, thank 
you very much.

> - Then you implied lua playlist scripts should really use XML/JSON
>   parsers. I gave it a fair try but showed why it didn't work.

I'm not sure that I did, but even then, so what? Lua playlist scripts should 
*obviously* use XML or JSON parsers if, and only if, their input is XML or 
JSON.

> - Then you changed your version and said it was to protect URL and
>   metadata consumers down the line. I explained why it didn't stand.

Distorting much? I said that the maximum length should not be a *parameter* 
because ultimately the suitable limit depends on final consumer.

> At every point I tried to engage constructively with you.

WTF? You literally made up design bugs in the API to divert the discussion 
from the actual issue. And you called my arguments "FUD".

I DARE YOU TO CALL THAT CONSTRUCTIVE AGAIN. You are just trolling.

-1 on patches 2-5.

-- 
Rémi Denis-Courmont
http://www.remlab.net/





More information about the vlc-devel mailing list