[vlc-devel] [PATCH 00/14] Move VLM implementation to a module

[Rémi Denis-Courmont]

Le tiistaina 15. syyskuuta 2020, 20.37.32 EEST Romain Vimont a écrit :
> This removes a lot of VLM code (including parsing) from libvlccore.

What is the actual point of this?

There is no point defining a module type if it does not save any dependencies 
within the core and there is only one single implementation. You're just 
making things more complicated by adding more boilerplate code and possibly 
exporting more functions. It won't even save memory in the case that VLM is 
not used, since it wouldn't be paged-in either way.

In fact, in this case, vlc_cond_timedwait_daytime() does not even work 
correctly except on Linux. So unless you're going to actually fix it, you'd 
expose it less (remove it) than more.

Converting VLM or parts of it into an interface module? Fixing bugs? Removing 
useless code? great. Adding a new module type? no thanks.

-- 
Реми Дёни-Курмон
http://www.remlab.net/