[vlc-devel] [PATCH v2 00/18] ThreadDisplayPicture cleaning
Steve Lhomme
robux4 at ycbcr.xyz
Wed Sep 16 13:14:26 CEST 2020
Changes since v1:
- kept the reuse parameter as it can actually be used after a flush that kept
the lasted decoded+prepared picture because its timestamp was before the
flush limit (see vout_Flush in ModuleThread_PlayVideo)
- rework the forced redisplay when filters change, deinterlace is not
considered, nor the first picture so we don't mess its first display time.
- only log dropped frame when it's dropped (it's dropped only if it was never
displayed)
- don't touch force_refresh for now (it's complicated)
- renamed INVALID_DEADLINE to INFINITE_DEADLINE
- removed if part that only contained a comment
- add more explanations on some patches
Steve Lhomme (18):
video_output: don't set a value on unused variable
video_output: compute the date_refresh earlier in
ThreadDisplayRenderPicture
video_output: set the deadline early when there was a previous frame
displayed
video_output: set the deadline directly when the next frame date is
known
video_output: count the pictures dropped
video_output: rename drop_next_frame to display_next_frame
video_output: rename refesh to current_needs_redisplay
video_output: do not use the frame skipping mode if no frame was
displayed
video_output: use INT64_MAX for the invalid control pop deadline
video_output: rework the first frame prepare
video_output: rename is_forced to immediate
video_output: render the picture immediately if filters changed
video_output: return early if we tried to render pictures but none
were found
video_output: return the rendered picture in
ThreadDisplayPreparePicture
video_output: only set displayed.next on the second
ThreadDisplayPreparePicture call
video_output: return error if we don't have a next picture to display
video_output: move the display skipping return
video_output: merge some test with a previous test
src/video_output/control.c | 2 +-
src/video_output/control.h | 2 +
src/video_output/video_output.c | 132 ++++++++++++++++----------------
3 files changed, 71 insertions(+), 65 deletions(-)
--
2.26.2
More information about the vlc-devel
mailing list