[vlc-devel] [PATCH] stream: expose vlc_stream_Control symbol

[Alexandre Janniaux]

Hi,

On Thu, Sep 17, 2020 at 08:25:10PM +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 16. syyskuuta 2020, 22.33.33 EEST Romain Vimont a écrit :
> > The stream "control" function is exposed in 2 variants:
> >  - vlc_stream_vaControl(), with a va_list parameter;
> >  - vlc_stream_Control(), with a variable number of arguments.
> >
> > From Rust, the va_list version could only be called using the
> > "c_variadic" feature, currently unstable:
> > https://doc.rust-lang.org/std/ffi/struct.VaList.html
> >
> > However, the variadic version (vlc_stream_Control()) can be called:
> > https://doc.rust-lang.org/nomicon/ffi.html#variadic-functions
>
> I empirically believe that it's a few years too early to freeze the minimum
> required Rust version. Who knows what *other* relevant feature Rust itself or
> the Rust C bindings will develop in the next few years.
>
> If the support is merged in the development branch, just use it. You can
> always adjust later if needed.

The point of not using the nightly of Rust is to avoid transitional
features added as an experiment that will typically break the CI if
Rustc version is not pinned.

This is with high probability not the case for `va_list` support so
that's why we can just opt-in for nightly in the generated bindings
but keep stable for the stable API.

I'm not sure we need more than what is required for the bindings.
Fancy sugar is great but we can wait stable, like with C++.

Regards,
--
Alexandre Janniaux
Videolabs