[vlc-devel] [PATCH] stream: expose vlc_stream_Control symbol

[Romain Vimont]

On Thu, Sep 17, 2020 at 08:25:10PM +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 16. syyskuuta 2020, 22.33.33 EEST Romain Vimont a écrit :
> > The stream "control" function is exposed in 2 variants:
> >  - vlc_stream_vaControl(), with a va_list parameter;
> >  - vlc_stream_Control(), with a variable number of arguments.
> > 
> > From Rust, the va_list version could only be called using the
> > "c_variadic" feature, currently unstable:
> > https://doc.rust-lang.org/std/ffi/struct.VaList.html
> > 
> > However, the variadic version (vlc_stream_Control()) can be called:
> > https://doc.rust-lang.org/nomicon/ffi.html#variadic-functions
> 
> I empirically believe that it's a few years too early to freeze the minimum 
> required Rust version. Who knows what *other* relevant feature Rust itself or 
> the Rust C bindings will develop in the next few years.
> 
> If the support is merged in the development branch, just use it. You can 
> always adjust later if needed.

Unstable features require a nightly Rust compiler. It's not worth it, we
don't need it by just exposing the variadic function symbol.

Regards