[vlc-devel] Add rust backed cuesheet parser

Alexandre Janniaux ajanni at videolabs.io
Wed Sep 23 10:52:50 CEST 2020


Hi,

On Wed, Sep 23, 2020 at 10:42:31AM +0200, Marvin Scholz wrote:
>
>
> On 23 Sep 2020, at 9:40, Thomas Guillem wrote:
>
> > On Wed, Sep 23, 2020, at 08:58, Kartik Ohri wrote:
> > > Hi!
> > > If there are no objections, can this patchset be merged ?
> >
> > No, it can't be merged as it is. TODO:
> >  - proper configure integration: --disable-rust/--enable-rust
> >  - Decide if it's enabled or not by default
> >  - Decide it rust build can break because we don't want to bother C
> > developers to fix Rust code for now.
> >  - Using cargo from system or from contrib ?
> >  - CI integration
> >  - Rust fmt integration
>
> What do you mean by rustfmt integration?
> Thats a task for CI not the build system, so not sure
> this is really a blocking issue?

Yes, because we don't want non-compliant rust code to be
merged before the CI prevents it. Otherwise it might
become really painful.

Regards,
--
Alexandre Janniaux
Videolabs


More information about the vlc-devel mailing list