[vlc-devel] [PATCH v1 01/33] filter: add a function to do the picture filtering

Steve Lhomme robux4 at ycbcr.xyz
Mon Sep 28 10:05:58 CEST 2020


On 2020-09-28 9:26, Alexandre Janniaux wrote:
> Hi,
> 
> I don't really appreciate to be asked to write a full refactor
> of the filter code (which is quite time consuming) only to have
> someone rework the code differently before I submit my work. :(
> 
> https://patches.videolan.org/patch/28297/

I don't understand. Your patch is about adding close callback to the 
filter. This is unrelated to this patch or even the patchset which 
doesn't touch that part of the filters.

If you have other patches that impact what I changed then show them. You 
can't expect me to guess what you have done in private 2 months ago.

> On Fri, Sep 25, 2020 at 04:46:37PM +0200, Steve Lhomme wrote:
>> ---
>>   include/vlc_filter.h | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/include/vlc_filter.h b/include/vlc_filter.h
>> index d9c274a645a..6197cec2c9b 100644
>> --- a/include/vlc_filter.h
>> +++ b/include/vlc_filter.h
>> @@ -191,6 +191,11 @@ static inline picture_t *filter_NewPicture( filter_t *p_filter )
>>       return pic;
>>   }
>>
>> +static inline picture_t *filter_FilterSingle( filter_t *p_filter, picture_t *pic )
>> +{
>> +    return p_filter->pf_video_filter( p_filter, pic );
>> +}
>> +
>>   /**
>>    * Flush a filter
>>    *
>> --
>> 2.26.2
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list