[vlc-devel] [PATCH 0/5] options: fix missing since tags and purge the very old

[Lyndon Brown]

On Mon, 2020-09-28 at 09:59 +0200, Steve Lhomme wrote:
> The patchset LGTM.

Great :)

> Did you also double check that the variables are not used anymore in
> the 
> code ?

Hmm, I don't recall. I'll double check now...

So the only issues I noticed:
 - x264 has a few references in it's chain parse list which need
removing.
 - the macosx gui is still handling --server-port.

I'm not totally certain about --volume and --language, since "volume"
and "language" are such common strings and not so easy to assess.

I've attached a fresh copy of the patches, adding a new initial one to
address the x264 issue, and to leave --server-port in place for now.


> On 2020-09-25 18:41, Lyndon Brown wrote:
> > This applies on top of "help output categorisation fixes" sent on
> > the
> > 17th. (Apologies if being a little impatient).
> > 
> > The first patch adds missing 'since' version tags to all obsolete
> > options that are missing them.
> > 
> > The other four patches purge long-obsolete options that became
> > obsolete
> > in pre-v2.0, v2.0, v2.1, and v2.2 respectively.
> > 
> > I neglected to do the same for options obsoleted in v3.0 since I
> > felt
> > that was likely to be considered too recent, though I can add an
> > additional patch for this if wanted.
> > 
> > This removes a total of ~165 option definitions (of course not all
> > will
> > apply to everyone), with ~50 being booleans, thus slimming down the
> > total options to match arguments against by a total of 265 (each
> > bool
> > is three not two, as to be discussed later).
> > 
> > Previews to follow as replies as before.
> > 
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01.patch
Type: text/x-patch
Size: 1517 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200928/01cbf8a3/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02.patch
Type: text/x-patch
Size: 14976 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200928/01cbf8a3/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03.patch
Type: text/x-patch
Size: 13051 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200928/01cbf8a3/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04.patch
Type: text/x-patch
Size: 10697 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200928/01cbf8a3/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 05.patch
Type: text/x-patch
Size: 11632 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200928/01cbf8a3/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 06.patch
Type: text/x-patch
Size: 5170 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200928/01cbf8a3/attachment-0011.bin>