[vlc-devel] [PATCH 0/5] options: fix missing since tags and purge the very old

[Steve Lhomme]

  /* Advanced options */
+    set_category( CAT_ADVANCED )
      set_subcategory( SUBCAT_ADVANCED_MISC )

This doesn't belong in this patchset (04.patch).

"volume" seems to be an internal only variable.
"language" doesn't seem to be used. The same string is used as a meta data.

On 2020-09-28 22:38, Lyndon Brown wrote:
> On Mon, 2020-09-28 at 09:59 +0200, Steve Lhomme wrote:
>> The patchset LGTM.
> 
> Great :)
> 
>> Did you also double check that the variables are not used anymore in
>> the
>> code ?
> 
> Hmm, I don't recall. I'll double check now...
> 
> So the only issues I noticed:
>   - x264 has a few references in it's chain parse list which need
> removing.
>   - the macosx gui is still handling --server-port.
> 
> I'm not totally certain about --volume and --language, since "volume"
> and "language" are such common strings and not so easy to assess.
> 
> I've attached a fresh copy of the patches, adding a new initial one to
> address the x264 issue, and to leave --server-port in place for now.
> 
> 
>> On 2020-09-25 18:41, Lyndon Brown wrote:
>>> This applies on top of "help output categorisation fixes" sent on
>>> the
>>> 17th. (Apologies if being a little impatient).
>>>
>>> The first patch adds missing 'since' version tags to all obsolete
>>> options that are missing them.
>>>
>>> The other four patches purge long-obsolete options that became
>>> obsolete
>>> in pre-v2.0, v2.0, v2.1, and v2.2 respectively.
>>>
>>> I neglected to do the same for options obsoleted in v3.0 since I
>>> felt
>>> that was likely to be considered too recent, though I can add an
>>> additional patch for this if wanted.
>>>
>>> This removes a total of ~165 option definitions (of course not all
>>> will
>>> apply to everyone), with ~50 being booleans, thus slimming down the
>>> total options to match arguments against by a total of 265 (each
>>> bool
>>> is three not two, as to be discussed later).
>>>
>>> Previews to follow as replies as before.
>>>
>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel