[vlc-devel] [PATCH] sd: remove -S/--services-discovery option

[Pierre Ynard]

> That says nothing about out-of-tree users. Lua bindings are
> not internals, they're an external API, and breaking it is not
> insignificant.

> In fact vlc.sd.add() is pretty much like -S: we don't want to remove
> it, we want to keep it and keep it loading SD, and find a new way to
> make those SD accessible.

I think that at the very least, the C part of
https://git.videolan.org/?p=vlc.git;a=commitdiff;h=3159dad5eb99b3c2a3267efc8af2fcc9c113cd55
needs to be reverted, if only for get_services_names() to return an
empty list, and add() and remove() to be no-ops. The documentation needs
to be brought back if only to say: "Deprecated - don't use".

More substantially, I think like solution 1/ for -S, these bindings
should be reimplemented using the new APIs, even without a way to
access the loaded modules yet. Then, if there is no core SD facility,
vlc.sd.add() could return a usable tree object. If we want a core SD
facility, we'd want to expose it through new lua bindings.

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."