[vlc-devel] PATCH: librist based access and access_output modules
thomas at gllm.fr
Wed Feb 3 09:12:42 UTC 2021
it's hard to review a .patch file.
Please send your patch inline or send a link to a gitlab/github MR/branch.
I would really prefer if we remove the old one when adding this new one. If you are not sure libRIST is built on all platforms supported by VLC, just do a merge request to your own repo, with contrib librist, and the librist module in order to trigger the CI. That way, we will know which platforms need fixes.
On Wed, Feb 3, 2021, at 02:43, Sergio M. Ammirata, Ph.D. wrote:
> Any feedback?
> On Thu, 2021-01-14 at 22:22 -0500, Sergio M. Ammirata, Ph.D. wrote:
>> Here is a revised patch with compatible config settings (all items below fixed). I also reduced the number of settings to the minimum required.
>> On Sun, 2020-12-27 at 16:39 +0100, Jean-Baptiste Kempf wrote:
>>> On Sun, 27 Dec 2020, at 14:15, Sergio M. Ammirata, Ph.D. wrote:
>>>> The config options do not match 100% either. Here is the analysis on the config options:
>>>> 1) The config for the buffer size is called "latency" on native rist and "buffer" in the librist module.
>>> Fix this.
>>>> 2) There are a few config options present in native rist that do not exist on the librist module (packet-size, maximum-jitter, nack-type, disable-nacks, mcast-blind-nacks).
>>> Fix this.
>>>> 3) There are a number of new config options present in librist module that do not exist in native rist. These are expected as the new settings/options are related to encryption, selecting profile levels, multiplexing, multipath, congestion control and timing mode.
>>> Remove the unneeded ones. We have too many already.
>>> Jean-Baptiste Kempf - President
>>> +33 672 704 734
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel