[vlc-devel] PATCH: librist based access and access_output modules

[Alexandre Janniaux]

Hi,


> +### LIBRIST ###
> +
> +librist_plugin_la_SOURCES = access/librist.c
> +librist_plugin_la_CFLAGS = $(AM_CFLAGS)
> +librist_plugin_la_LIBADD = $(LIBRIST_LIBS) $(SOCKET_LIBS) $(LIBPTHREAD)
> +access_LTLIBRARIES += librist_plugin.la

Since you use

> +dnl
> +dnl  libRIST plugin
> +dnl
> +PKG_ENABLE_MODULES_VLC([LIBRIST], [], [librist], [RIST input/output plugin (default auto)])
> +

You should write

extra_LTLIBRARIES += librist_plugin.la
+access_LTLIBRARIES += $(LTLIBlibrist)

And use «rist» as module name instead

+dnl
+dnl  libRIST plugin
+dnl
+PKG_ENABLE_MODULES_VLC([LIBRIST], [rist], [librist], [RIST input/output plugin (default auto)])
+

Also, $(LIBRIST_LIBS) would probably be better in its more generic
form $(LIBS_rist) here since you enable the plugin with this call,
and you'll need to add $(CFLAGS_rist) too.

Without this, you'll try to build librist_plugin.la even with
--disable-librist which would fail, and it would not work correctly
with librist found with pkg-config somewhere on the system.

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Jan 14, 2021 at 10:22:59PM -0500, Sergio M. Ammirata, Ph.D. wrote:
>
> Here is a revised patch with compatible config settings
> (all items below fixed). I also reduced the number of
> settings to the minimum required.
> Regards,
> Sergio
> On Sun, 2020-12-27 at 16:39 +0100, Jean-Baptiste Kempf
> wrote:
> > On Sun, 27 Dec 2020, at 14:15, Sergio M. Ammirata, Ph.D.
> > wrote:
> > > The config options do not match 100% either. Here is
> > > the analysis on the config options:
> > > 1) The config for the buffer size is called "latency"
> > > on native rist and "buffer" in the librist module.
> >
> > Fix this.
> >
> > > 2) There are a few config options present in native
> > > rist that do not exist on the librist module (packet-
> > > size, maximum-jitter, nack-type, disable-nacks, mcast-
> > > blind-nacks).
> >
> > Fix this.
> >
> > > 3) There are a number of new config options present in
> > > librist module that do not exist in native rist. These
> > > are expected as the new settings/options are related to
> > > encryption, selecting profile levels, multiplexing,
> > > multipath, congestion control and timing mode.
> >
> > Remove the unneeded ones. We have too many already.
> >
> > Best,
> >
> > --
> > Jean-Baptiste Kempf -  President
> > +33 672 704 734
> >
> >
> >
> >


> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel