[vlc-devel] [PATCH 08/10] vout: don't clobber crop borders when updating

[Rémi Denis-Courmont]

Hi,

If the user requested crop in pixel values, we should obey. We're talking about a command line option here. It does not apply to just the first encountered video format. That's literally the only reason why we distinguish window and border crop...

If the user wants a crop ratio, then they should specify a ratio. That's what happens if they use the GUI menu or the C hotkey.

We could a crop (centered) zoom mode if we want to crop proportionally in both dimensions. But I have never seen a request for that, so it sounds like a pure for-the-sake-completeness academic exercise.

Le 8 février 2021 12:52:33 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>On 2021-02-08 11:49, Rémi Denis-Courmont wrote:
>> Le maanantaina 8. helmikuuta 2021, 9.58.58 EET Steve Lhomme a écrit :
>>> If the code is next called with vout_UpdateDisplaySourceProperties()
>>> osys->crop.left (and the others) will be 0. This effectively resets
>a
>>> previous call to vout_SetDisplayCrop(). I don't know if it's
>intentional
>>> or not.
>> 
>> I tihnk it's left-over from the old vout display management loop and
>its error
>> handling.
>> 
>>> I don't think there's a good way to handle this case: the user
>>> set a manual crop on certain video dimension and then the video
>>> dimension changes.
>> 
>> That's the FIXME that this patch fixes and removes: We need to keep
>track of
>> the _crop mode_, so that the effective crop window can be recomputed
>in
>> accordance with user settings even if the source format changes.
>
>So if I have a 1280x720 video on which I crop 500 pixels on the left,
>if 
>the dimension changes to 640x480 I still crop 500 pixels ?
>It may not what the user expects. It may be better to apply a factor to
>
>the crop.
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210208/4b7efdcd/attachment.html>