[vlc-devel] [PATCH] mp3: id3: support id3v2.4 tag for id3 chapter markers

Rémi Denis-Courmont remi at remlab.net
Thu Feb 18 18:18:26 UTC 2021

Le torstaina 18. helmikuuta 2021, 16.00.41 EET Wang Gary a écrit :
> Hello,
> I'd like to re-ask for review since there are no replies or comments after
> a week, and here are some additional contexts about this patch:

Sorry about the delay but the original patch could really use more 
explanations of the changes...

> Previously VLC4 cannot load chapter markers from MP3 files that contain the
> ID3v2.4 tag, which caused by ID3TAG_ReadSize will always read the chunk
> size in an ID3v2.3 fashion. The syncsafe bit is also not used to determining
> how we read the chunk size here.

May well be so, but this would have belonged in the original patch 



More information about the vlc-devel mailing list