[vlc-devel] [PATCH v2 2/2] chromecast: fix deprecation warning

Alexandre Janniaux ajanni at videolabs.io
Thu Jan 21 11:58:08 UTC 2021


ByteSizeLong is available since 2016-09-23 version 3.1.0 according to
protobuf CHANGES.txt.
---
 modules/stream_out/chromecast/chromecast_communication.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/stream_out/chromecast/chromecast_communication.cpp b/modules/stream_out/chromecast/chromecast_communication.cpp
index 217d7a0e56..71bf51be75 100644
--- a/modules/stream_out/chromecast/chromecast_communication.cpp
+++ b/modules/stream_out/chromecast/chromecast_communication.cpp
@@ -437,7 +437,7 @@ unsigned ChromecastCommunication::msgPlayerSetVolume( const std::string& destina
  */
 int ChromecastCommunication::sendMessage( const castchannel::CastMessage &msg )
 {
-    int i_size = msg.ByteSize();
+    size_t i_size = msg.ByteSizeLong();
     uint8_t *p_data = new(std::nothrow) uint8_t[PACKET_HEADER_LEN + i_size];
     if (p_data == NULL)
         return VLC_ENOMEM;
@@ -451,7 +451,7 @@ int ChromecastCommunication::sendMessage( const castchannel::CastMessage &msg )
 
     ssize_t i_ret = vlc_tls_Write(m_tls, p_data, PACKET_HEADER_LEN + i_size);
     delete[] p_data;
-    if (i_ret > 0 && i_ret == PACKET_HEADER_LEN + i_size)
+    if (i_ret > 0 && (size_t)i_ret == PACKET_HEADER_LEN + i_size)
         return VLC_SUCCESS;
 
     msg_Warn( m_module, "failed to send message %s (%s)", msg.payload_utf8().c_str(), strerror( errno ) );
-- 
2.30.0



More information about the vlc-devel mailing list