[vlc-devel] [PATCH v2 1/2] chromecast: fix _Write return type

[Thomas Guillem]

Set LGTM

On Thu, Jan 21, 2021, at 12:58, Alexandre Janniaux wrote:
> vlc_tls_Write returns a ssize_t.
> ---
>  modules/stream_out/chromecast/chromecast_communication.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/stream_out/chromecast/chromecast_communication.cpp 
> b/modules/stream_out/chromecast/chromecast_communication.cpp
> index 347a15dbc6..217d7a0e56 100644
> --- a/modules/stream_out/chromecast/chromecast_communication.cpp
> +++ b/modules/stream_out/chromecast/chromecast_communication.cpp
> @@ -449,9 +449,9 @@ int ChromecastCommunication::sendMessage( const 
> castchannel::CastMessage &msg )
>      SetDWBE(p_data, i_size);
>      msg.SerializeWithCachedSizesToArray(p_data + PACKET_HEADER_LEN);
>  
> -    int i_ret = vlc_tls_Write(m_tls, p_data, PACKET_HEADER_LEN + i_size);
> +    ssize_t i_ret = vlc_tls_Write(m_tls, p_data, PACKET_HEADER_LEN + i_size);
>      delete[] p_data;
> -    if (i_ret == PACKET_HEADER_LEN + i_size)
> +    if (i_ret > 0 && i_ret == PACKET_HEADER_LEN + i_size)
>          return VLC_SUCCESS;
>  
>      msg_Warn( m_module, "failed to send message %s (%s)", 
> msg.payload_utf8().c_str(), strerror( errno ) );
> -- 
> 2.30.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel