[vlc-devel] [PATCH] fetcher: fix use-after-free on error

Romain Vimont rom1v at videolabs.io
Sun Jan 24 17:33:09 UTC 2021


A "goto out;" was left on the error branch, causing the task to be used-
after-free.
---
 src/preparser/fetcher.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/preparser/fetcher.c b/src/preparser/fetcher.c
index 7616078ff8..6fe6036df4 100644
--- a/src/preparser/fetcher.c
+++ b/src/preparser/fetcher.c
@@ -375,7 +375,6 @@ error:
     NotifyArtFetchEnded(task, false);
     FetcherRemoveTask(fetcher, task);
     TaskDelete(task);
-    goto out;
 }
 
 static void RunSearchLocal(void *userdata)
-- 
2.30.0



More information about the vlc-devel mailing list