[vlc-devel] [PATCH] fetcher: fix use-after-free on error

[Alexandre Janniaux]

Hi,

LGTM, will merge soon.

Regards,
--
Alexandre Janniaux
Videolabs

On Sun, Jan 24, 2021 at 06:33:09PM +0100, Romain Vimont wrote:
> A "goto out;" was left on the error branch, causing the task to be used-
> after-free.
> ---
>  src/preparser/fetcher.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/preparser/fetcher.c b/src/preparser/fetcher.c
> index 7616078ff8..6fe6036df4 100644
> --- a/src/preparser/fetcher.c
> +++ b/src/preparser/fetcher.c
> @@ -375,7 +375,6 @@ error:
>      NotifyArtFetchEnded(task, false);
>      FetcherRemoveTask(fetcher, task);
>      TaskDelete(task);
> -    goto out;
>  }
>
>  static void RunSearchLocal(void *userdata)
> --
> 2.30.0
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel