[vlc-devel] [PATCH 3/3] transcode: video: fix insertion of fps filter

[Rémi Denis-Courmont]

Le tiistaina 26. tammikuuta 2021, 21.16.39 EET Francois Cartegnie a écrit :
> Le 26/01/2021 à 20:07, Alexandre Janniaux a écrit :
> > The dst es_format_t seems to be overriden no matter what,
> > before anything even happens, and the documentation doesn't
> > seem to require it either.
> > 
> > The init() copy() clean() cycle seems to only exist in bluray,
> > mp4, adaptive and a bit of transcode.
> > 
> > What would seem harmful to me is calling es_format_Clean() on
> > a non-initialized es_format but it's clearly initialized right
> > after it's declaration by es_format_Copy, or maybe I miss
> > something there.
> 
> If copy does init, then what copy after copy does ?
> It leaks or... it needs to clean which makes earlier init mandatory.
> 
> That's one example why we should have kept full init() clean() cycles
> everywhere, and even if the init is zero op.

We cannot keep something we literally never had. And lets not even get started 
on lack of error handling and the probability to make it happen without 
introducing even more bugs.

Unlike video_format_t, there are no realistic ways that we could make 
es_format_t serial, but your argument is simply invalid, and so far nobody 
really came up with a good idea.

-- 
Реми Дёни-Курмон
http://www.remlab.net/