[vlc-devel] [PATCH 3/3] transcode: video: fix insertion of fps filter

[Francois Cartegnie]

Le 26/01/2021 à 22:03, Rémi Denis-Courmont a écrit :

>> That's one example why we should have kept full init() clean() cycles
>> everywhere, and even if the init is zero op.
> 
> We cannot keep something we literally never had. And lets not even get started
> on lack of error handling and the probability to make it happen without
> introducing even more bugs.

I remember did remove the union at some point

> Unlike video_format_t, there are no realistic ways that we could make
> es_format_t serial, but your argument is simply invalid, and so far nobody
> really came up with a good idea.

There was enough discussions on this ml when ^above happened. filip and 
I were pushing for a full cycle API and cleanup the es_format mess, some 
people didn't want because there was "no need".

-- 
Francois Cartegnie
VideoLAN - VLC Developer