[vlc-devel] [PATCH 01/11] os2: thread: implement missing threading functions

Steve Lhomme robux4 at ycbcr.xyz
Fri Jan 29 15:06:57 UTC 2021


On 2021-01-25 10:36, KO Myung-Hun wrote:
> Hi/2.
> 
> Steve Lhomme wrote:
>> Patchset LGTM, at least it's mostly OS/2 specific code.
>>
> 
> Then how about committing ? ^______^

Done.

Now could you rework the code to avoid the remaining OS2 specific things 
in the core ?

For example is it possible to handle this in the window_os2.c file ?

         case WM_VRNENABLED :
             if( !vd->cfg->is_fullscreen && sys->is_on_top )
                 WinSetWindowPos( hwnd, HWND_TOP, 0, 0, 0, 0, SWP_ZORDER );
             break;

Also the VOUT_DISPLAY_CHANGE_FULLSCREEN and 
VOUT_DISPLAY_CHANGE_WINDOW_STATE should not be needed anymore. There are 
handled by your window module as well.


More information about the vlc-devel mailing list