[vlc-devel] [PATCH 01/11] os2: thread: implement missing threading functions

[KO Myung-Hun]

Hi/2.

Steve Lhomme wrote:
> On 2021-01-25 10:36, KO Myung-Hun wrote:
>> Hi/2.
>>
>> Steve Lhomme wrote:
>>> Patchset LGTM, at least it's mostly OS/2 specific code.
>>>
>>
>> Then how about committing ? ^______^
> 
> Done.
> 

Thanks!

> Now could you rework the code to avoid the remaining OS2 specific things
> in the core ?
> 
> For example is it possible to handle this in the window_os2.c file ?
> 
>         case WM_VRNENABLED :
>             if( !vd->cfg->is_fullscreen && sys->is_on_top )
>                 WinSetWindowPos( hwnd, HWND_TOP, 0, 0, 0, 0, SWP_ZORDER );
>             break;
> 
> Also the VOUT_DISPLAY_CHANGE_FULLSCREEN and
> VOUT_DISPLAY_CHANGE_WINDOW_STATE should not be needed anymore. There are
> handled by your window module as well.

Ok. I'll try soon.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v6.1.10 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/