[vlc-devel] [PATCH 2/4] doc: add an option to build libvlc sample app from the documentation

[Alexandre Janniaux]

Hi,

On Fri, Mar 05, 2021 at 08:18:15AM +0100, Steve Lhomme wrote:
> On 3/4/2021 3:34 PM, Alexandre Janniaux wrote:
> > Hi,
> >
> > On Thu, Mar 04, 2021 at 11:42:02AM +0100, Steve Lhomme wrote:
> > > On 3/1/2021 11:15 AM, Marvin Scholz wrote:
> > > >
> > > >
> > > > On 1 Mar 2021, at 7:41, Steve Lhomme wrote:
> > > >
> > > > > This is not a file we use in our build system. It's there for
> > > > > documentation purpose, to guide users.
> > > > > That doesn't mean there's only one way to build Qt project. We use
> > > > > autotools to build our own Qt module. In the past I've used others
> > > > > as well. I believe nowadays CMAKE is also a candidate. We'll
> > > > > probably use Meson for it as well.
> > > > > Pushing for qmake here when we already have all the autotools parts
> > > > > ready and solid to do it make no sense to me.
> > > > >
> > > > >
> > > > > Otherwise you should advocate to add MSVC projects for libvlc and
> > > > > build windows samples with it since that's what a lot of people will
> > > > > use.
> > > > >
> > > >
> > > > I agree with what Alexandre already wrote, duplicating the build in
> > > > autotools here seems incredibly awful choice
> > > > for nearly no benefit at all… Just use qmake to build the sample
> > > > project, like most users of it would do?
> > > > I am not sure who would benefit from having another build for this in
> > > > autotools, which can be painful to use
> > > > properly with Qt, or nearly impossible even, on macOS. And additionally
> > > > can easily get out of sync when
> > > > someone is unaware of the other build system for it and makes changes
> > > > only updating the autotools build for it…
> > > >
> > > > Your point about MSVC does not really make sense to me, as this is a
> > > > completely different topic, really.
> > >
> > > Nope. this is exactly the confusion you are both making between building the
> > > samples when building VLC and building the samples in an external context
> > > with the purpose of integrating libvlc in an app.
> >
> > No, I think you're confusing what a sample project is and what
> > a test is. Using samples for the coverage of libvlc API is not
> > correct.
> >
> > Don't get me wrong, checking that the libvlc samples are correct
> > _is_ a good move IMHO, like I already mentioned, but if you're
> > not testing the buildsystem you're shipping in the documentation
> > then the check makes no sense and it's quite easy to understand
>
> I agree we can remove the dummy build project since we don't use it anyway.
> Other samples don't have this luxury. And as explained before we can't
> assume what build system people will use for their own system (ie we're not
> adding msvc+cmake+meson for win32 samples just because someone might use
> that).

Which dummy build project?