[vlc-devel] [PATCH] http: improve FIXME comment for digest authentication handling

[MANJEET YADUVANSHI]

Hi,

This patch improves a FIXME comment in the Digest authentication handling
code.

The updated comment clarifies that repeated Digest authentication headers
are not currently handled, making the limitation more explicit for future
contributors.

No functional changes are introduced.

Thanks,
Manjeet

>From 62816b609e62eb9bd0abbbd58aae647fd7e09e5a Mon Sep 17 00:00:00 2001
From: Manjeet Yaduvanshi <manjeetyaduvanshi250 at gmail.com>
Date: Thu, 9 Apr 2026 23:32:57 +0530
Subject: [PATCH] http: improve FIXME comment for digest authentication
 handling

---
 src/network/http_auth.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/network/http_auth.c b/src/network/http_auth.c
index 572db699d6..3f27bbe045 100644
--- a/src/network/http_auth.c
+++ b/src/network/http_auth.c
@@ -234,8 +234,10 @@ void vlc_http_auth_ParseWwwAuthenticateHeader(
         msg_Dbg( p_this, "Using Digest Access Authentication" );

         if ( p_auth->psz_nonce )
-            /* FIXME */
+        {
+            /* FIXME: Handle repeated Digest authentication headers properly */
             return;
+        }

         psz_header += sizeof( psz_digest_prefix ) - 1;
         p_auth->psz_realm = AuthGetParam( psz_header, "realm" );
-- 
2.53.0.windows.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20260416/d4cbb6cc/attachment.htm>