[vlc-devel] [PATCH] input: improve TODO comment for function naming clarity

MANJEET YADUVANSHI manjeetyaduvanshi250 at gmail.com
Sat Apr 18 10:06:32 UTC 2026


Hi,

This patch improves a TODO comment related to function naming.

The updated comment makes it clearer that the function name should better
describe its behavior.

No functional changes are introduced.

Thanks,
Manjeet

>From 6a957b0379aac0dfc0dd10e805e2d084b7e026c5 Mon Sep 17 00:00:00 2001
From: Manjeet Yaduvanshi <manjeetyaduvanshi250 at gmail.com>
Date: Fri, 3 Apr 2026 16:01:56 +0530
Subject: [PATCH] input: improve TODO comment for function naming clarity

---
 src/input/input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/input/input.c b/src/input/input.c
index 6cd40c5fb7..7d8b961fc7 100644
--- a/src/input/input.c
+++ b/src/input/input.c
@@ -112,7 +112,7 @@ static void AppendAttachment(input_thread_t* p_input,
 static int input_SlaveSourceAdd( input_thread_t *, enum slave_type,
                                  const char *, unsigned );
 static char *input_SubtitleFile2Uri( input_thread_t *, const char * );
-static void input_ChangeState( input_thread_t *p_input, int i_state,
vlc_tick_t ); /* TODO fix name */
+static void input_ChangeState( input_thread_t *p_input, int i_state,
vlc_tick_t ); /* TODO: Rename this function to better describe its
behaviour */

 /**
  * Start a input_thread_t created by input_Create.
-- 
2.53.0.windows.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20260418/b4081ac0/attachment.htm>


More information about the vlc-devel mailing list