VLC 2.82 on RH 7.2

[Gildas Bazin]

On Sunday 19 August 2001 3:35 am, brash wrote:
> Hi all,
> 
> I have a Toshiba Satellite with a 1GHz Pentium III processor and an
> NVidia GeForce2go graphics chip.  I have the NVidia drivers properly
> installed, and 3D games (like quake III arena) run killer.
> 
> I downloaded VLC 2.82 and compiled from source.  SDL and xvideo both claim
> to be supported, but when I try to run it with either, all I get is a
> giant block of solid blue where the video should be.  Audio plays fine.
> 

I've included below a mail from Marcel J.E. MOL, try to apply his patch and 
hopefully xvideo should work.

--
Gildas

On Sun, 12 Aug 2001 Marcel J.E. Mol wrote:

I managed to get vlc working om my Inspiron 8000/Nvidia Geforce2 with
the Xvideo extension.
As said before the Ogle player worked fine using Xvideo. So I compared
how ogle and vlc use xvideo.
I don't know much about X programming and the Xvidoe extension but 
anyway this is what I saw and changed:
Apperantly xvideo allows for severla 'adaptors'. Now vlc just takes
the first one that matches with the wanted 'ImageFormat' (YUV12).
Ogle takes a different aproach and uses the last adaptor. 
Now it seems the nvidia card/driver has two adaptors. The first
one called "NV10 Video Overlay" and a second one called "NV05 Video Blitter".

So I changed vlc to also use the last one and voila, I get Xvideo!
Now the only problem there is I do not get subtitles...

The patch to vlc is quite simple. Again as I don;t now much on X/Xvideo
programming I don't know the impact on other parts of vlc.

--- vlc-0.2.82/plugins/x11/vout_xvideo.c        Fri Aug 10 01:13:32 2001
+++ vlc-0.2.82mm/plugins/x11/vout_xvideo.c      Sun Aug 12 22:21:07 2001
@@ -1194,7 +1194,7 @@
             return( -1 );
     }
 
-    for( i=0; i < i_adaptors && xv_port == -1; ++i )
+    for( i=0; i < i_adaptors ; ++i )
     {
         if( ( adaptor_info[ i ].type & XvInputMask ) &&
             ( adaptor_info[ i ].type & XvImageMask ) )
@@ -1206,7 +1209,7 @@
 
             imageFormats = XvListImageFormats( dpy, port, &i_num_formats );
 
-            for( i=0; i < i_num_formats && xv_port == -1; ++i )
+            for( i=0; i < i_num_formats; ++i )
             {
                 if( imageFormats[ i ].id == GUID_YUV12_PLANAR )
                 {


Anyone with some xvideo knowledge wold like to comment?

-Marcel