vlc-cvs coredumps, debug mode patch (PLUS FIX!)

Steven M. Schultz sms at 2BSD.COM
Fri Dec 28 20:28:33 CET 2001


Greetings -

	I have solved the problem of vlc coredumping in DVDRead.  A NULL
	pointer was indeed being dereferenced!

	The fix below allows me to play "The Angry Red Planet" just fine.

	IF you enable verbose level 2 you do see a lot of "pp_data NULL"
	messages but the program keeps running fine!

	Hope the developers pick up on this :)

	Thanks.

	Steven Schultz
	sms at 2bsd.com

--------------------------------------
--- plugins/dvd/input_dvd.c.dist	Fri Dec 28 08:34:47 2001
+++ plugins/dvd/input_dvd.c	Fri Dec 28 11:27:41 2001
@@ -979,7 +979,10 @@
     p_input->pf_delete_packet( p_input->p_method_data, p_data );
     if( i_packet != 0 )
     {
-        (*pp_data)->p_next = NULL;
+	if (*pp_data == NULL)
+	   intf_WarnMsg( 1, "pp_data NULL");
+	else
+            (*pp_data)->p_next = NULL;
     }
 
     vlc_mutex_lock( &p_input->stream.stream_lock );




More information about the vlc mailing list