[vlc] bug in linux_dvb.c with code-rate parameters

[Guido Flohr]

Hi,

there is a (fatal!) typo in modules/access/dvb/linux_dvb.c.  In function 
FrontendSetOFDM():

Index: linux_dvb.c
===================================================================
--- linux_dvb.c (revision 7978)
+++ linux_dvb.c (working copy)
@@ -811,9 +812,9 @@
      fep.inversion = DecodeInversion( p_input );

      fep.u.ofdm.bandwidth = DecodeBandwidth( p_input );
-    var_Get( p_input, "dvb-code-rate-HP", &val );
+    var_Get( p_input, "dvb-code-rate-hp", &val );
      fep.u.ofdm.code_rate_HP = DecodeFEC( p_input, val.i_int );
-    var_Get( p_input, "dvb-code-rate-LP", &val );
+    var_Get( p_input, "dvb-code-rate-lp", &val );
      fep.u.ofdm.code_rate_LP = DecodeFEC( p_input, val.i_int );
      fep.u.ofdm.constellation = DecodeModulation( p_input );
      fep.u.ofdm.transmission_mode = DecodeTransmission( p_input );

=== end of patch ===

The effect of the typo is that both code_rate_HP and code_rate_LP are 
always set to FEC_NONE in the frontend parameters for DVB-T cards.  When 
tuning the card you get "dvb input error: argument has invalid FEC 
(650000000)" (where 650000000 is the frequency you want to tune in).

Alternatively, you could also change the name of the parameters in 
moduales/access/dvb/access.c, up to you.

I would also recommend this change:

Index: linux_dvb.c
===================================================================
--- linux_dvb.c (revision 7978)
+++ linux_dvb.c (working copy)
@@ -405,6 +406,7 @@

      switch ( i_val )
      {
+       case 0: fe_fec = FEC_NONE; break;
          case 1: fe_fec = FEC_1_2; break;
          case 2: fe_fec = FEC_2_3; break;
          case 3: fe_fec = FEC_3_4; break;
=== end of patch ===

FEC_NONE is a legal value, it should not produce a warning.

Ciao

Guido
-- 
Imperia AG, Development
Leyboldstr. 10 - D-50354 Hürth - http://www.imperia.net/

-- 
This is the vlc mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://www.videolan.org/support/lists.html
If you are in trouble, please contact <postmaster at videolan.org>