[vlmc-devel] [PATCH 07/12] MainWindow: remove unneeded arguments of renderVideo

Yikai Lu luyikei.qmltu at gmail.com
Wed Apr 6 09:58:20 CEST 2016


---
 src/Gui/MainWindow.cpp | 16 +++-------------
 src/Gui/MainWindow.h   |  3 +--
 2 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/src/Gui/MainWindow.cpp b/src/Gui/MainWindow.cpp
index 1a91087..75f02c3 100644
--- a/src/Gui/MainWindow.cpp
+++ b/src/Gui/MainWindow.cpp
@@ -599,11 +599,9 @@ MainWindow::checkVideoLength()
 }
 
 bool
-MainWindow::renderVideo( const QString& outputFileName, quint32 width, quint32 height,
-                         double fps, const QString& ar,
-                         quint32 vbitrate, quint32 abitrate )
+MainWindow::renderVideo( const QString& outputFileName )
 {
-    WorkflowFileRendererDialog  *dialog = new WorkflowFileRendererDialog( width, height );
+    WorkflowFileRendererDialog  *dialog = new WorkflowFileRendererDialog;
     dialog->setModal( true );
     dialog->setOutputFileName( outputFileName );
 
@@ -632,17 +630,9 @@ MainWindow::renderVideoSettings( bool shareOnInternet )
         return false;
     }
 
-    QString     outputFileName = settings->outputFileName();
-    quint32     width          = settings->width();
-    quint32     height         = settings->height();
-    double      fps            = settings->fps();
-    quint32     vbitrate       = settings->videoBitrate();
-    quint32     abitrate       = settings->audioBitrate();
-    auto        ar             = settings->aspectRatio();
-
     delete settings;
 
-    return renderVideo( outputFileName, width, height, fps, ar, vbitrate, abitrate );
+    return renderVideo( settings->outputFileName() );
 }
 
 QDockWidget*
diff --git a/src/Gui/MainWindow.h b/src/Gui/MainWindow.h
index 8f97d3a..35075b2 100644
--- a/src/Gui/MainWindow.h
+++ b/src/Gui/MainWindow.h
@@ -112,8 +112,7 @@ private:
      *          Also, displays a rendering dialog with snapshots and progress.
      *  \return true if video renders well or not cancelled by the user.
      */
-    bool        renderVideo( const QString& outputFileName, quint32 width, quint32 height,
-                             double fps, const QString& ar, quint32 vbitrate, quint32 abitrate );
+    bool        renderVideo( const QString& outputFileName );
 
     /**
      *  \brief  Gets video parameters from RendererSettings Dialog
-- 
1.9.1



More information about the Vlmc-devel mailing list