[vlmc-devel] [PATCH 06/12] RendererSettings: Set fps, height and width to the project's settings if they are acceptable

[yikei lu]

Well, if so I think it's better not to have an rendering dialog with
settings since it will be confusing.

2016-04-06 18:17 GMT+09:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
> On 04/06/2016 09:58 AM, Yikai Lu wrote:
>>
>> ---
>>   src/Gui/export/RendererSettings.cpp | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/src/Gui/export/RendererSettings.cpp
>> b/src/Gui/export/RendererSettings.cpp
>> index 7a8959e..7960726 100644
>> --- a/src/Gui/export/RendererSettings.cpp
>> +++ b/src/Gui/export/RendererSettings.cpp
>> @@ -111,12 +111,20 @@ RendererSettings::updateVideoPreset( int index )
>>   void
>>   RendererSettings::accept()
>>   {
>> +    auto project = Core::instance()->project();
>> +
>>       if ( width() <= 0 || height() <= 0 || fps() <= .0f )
>>       {
>>           QMessageBox::warning( this, tr( "Invalid parameters" ),
>>                                 tr( "Please enter valid rendering
>> parameters" ) );
>>           return;
>>       }
>> +    else
>> +    {
>> +        project->setFps( fps() );
>> +        project->setHeight( height() );
>> +        project->setWidth( width() );
>> +    }
>>
>>       QFileInfo fileInfo( m_ui.outputFileName->text() );
>>
>>
> Hi,
>
> I'm not sure this is a good idea.
> The way I see it, the project settings should be used as the default
> parameters for the rendering, but editing them for a specific render
> shouldn't impact the project settings.
>
> It's probably more of a UX question, that we need to have (winking at Felix
> & JB here)
>
> Regards,
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel