[vlmc-devel] [PATCH] WorkflowRenderer: Fix reading a null renderTarget.

[Hugo Beauzée-Luyssen]

On 05/01/2016 02:54 PM, Yikai Lu wrote:
> Sorry, it'a very stupid mistake.
> ---
>   src/Renderer/WorkflowRenderer.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Renderer/WorkflowRenderer.cpp b/src/Renderer/WorkflowRenderer.cpp
> index 23556bd..27e3516 100644
> --- a/src/Renderer/WorkflowRenderer.cpp
> +++ b/src/Renderer/WorkflowRenderer.cpp
> @@ -228,8 +228,8 @@ WorkflowRenderer::startRenderToFile( const QString& outputFileName, quint32 widt
>       m_outputFps = fps;
>       m_aspectRatio = ar;
>
> -    setupRenderer();
>       setRenderTarget( std::unique_ptr<Backend::IRenderTarget>( new Backend::FileTarget( qPrintable( outputFileName ) ) ) );
> +    setupRenderer();
>       m_sourceRenderer->setOutputAudioBitrate( abitrate );
>       m_sourceRenderer->setOutputVideoBitrate( vbitrate );
>       connect( m_mainWorkflow, &MainWorkflow::mainWorkflowEndReached, this, &WorkflowRenderer::renderComplete );
>
Oh indeed that isn't likely to work, I should have spotted it during review.
Applied, thanks :)