[vlmc-devel] [PATCH 6/8] TrackWorkflow: Use insertMulti

[Hugo Beauzée-Luyssen]

On 05/16/2016 10:34 AM, yikei lu wrote:
> I'll stick to one simultaneous media per track "type" like one
> simultaneous auido track and one simultaneous image track
> because one track will have to manage all of the types of media. Do
> you think it is still a bad idea?
> 
> FYI, in the future, I'll implement a collision detection in
> TrackWorkflow. We should also consider it.
> 
> Regards.
> 
> 2016-05-16 17:24 GMT+09:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
>> On 05/13/2016 11:52 AM, yikei lu wrote:
>>>
>>> I thought it would be convenient if we want to inseart some images and
>>> audio tracks in single Track.
>>>
>>>> "which media would you use for this track?"
>>>
>>> This is why I introduced Clip(Helper)::formats(). This will be used to
>>> determine what TrackType should be used. Also in the future, it could
>>> be also used to mute clips.
>>>
>>> 2016-05-13 18:14 GMT+09:00 Hugo Beauzée-Luyssen <hugo at beauzee.fr>:
>>>>
>>>> On 05/03/2016 07:24 AM, Yikai Lu wrote:
>>>>>
>>>>>
>>>>> More than one clip can be placed at a certain position.
>>>>> ---
>>>>>    src/Workflow/TrackWorkflow.cpp | 4 ++--
>>>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/src/Workflow/TrackWorkflow.cpp
>>>>> b/src/Workflow/TrackWorkflow.cpp
>>>>> index 295fc75..abf8736 100644
>>>>> --- a/src/Workflow/TrackWorkflow.cpp
>>>>> +++ b/src/Workflow/TrackWorkflow.cpp
>>>>> @@ -102,7 +102,7 @@ void
>>>>>    TrackWorkflow::addClip( ClipWorkflow* cw, qint64 start )
>>>>>    {
>>>>>        QWriteLocker    lock( m_clipsLock );
>>>>> -    m_clips.insert( start, cw );
>>>>> +    m_clips.insertMulti( start, cw );
>>>>>        connect( cw, SIGNAL( effectAdded( EffectHelper*, qint64 ) ),
>>>>>                 this, SLOT( __effectAdded( EffectHelper*, qint64 ) ) );
>>>>>        connect( cw, SIGNAL( effectMoved( EffectHelper*, qint64 ) ),
>>>>> @@ -380,7 +380,7 @@ TrackWorkflow::moveClip( const QUuid& id, qint64
>>>>> startingFrame )
>>>>>            {
>>>>>                ClipWorkflow* cw = it.value();
>>>>>                m_clips.erase( it );
>>>>> -            m_clips[startingFrame] = cw;
>>>>> +            m_clips.insertMulti( startingFrame, cw );
>>>>>                cw->requireResync();
>>>>>                computeLength();
>>>>>                emit clipMoved( this, cw->getClipHelper()->uuid(),
>>>>> startingFrame );
>>>>>
>>>> I disagree here, a single track can't contain multiple media at the same
>>>> position, which media would you use for this track?
>>>> _______________________________________________
>>>> Vlmc-devel mailing list
>>>> Vlmc-devel at videolan.org
>>>> https://mailman.videolan.org/listinfo/vlmc-devel
>>>
>>> _______________________________________________
>>> Vlmc-devel mailing list
>>> Vlmc-devel at videolan.org
>>> https://mailman.videolan.org/listinfo/vlmc-devel
>>>
>> I really think we should stick to one simultaneous media per track. No doing
>> so will probably be messy in the UI, IMHO.
>> Felix, JB, opinions?
>>
>> _______________________________________________
>> Vlmc-devel mailing list
>> Vlmc-devel at videolan.org
>> https://mailman.videolan.org/listinfo/vlmc-devel
> _______________________________________________
> Vlmc-devel mailing list
> Vlmc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlmc-devel
> 
As discussed a few days ago on IRC, it may be that merging tracks to
have a single tracks stack was a bad idea.
I'd like to postpone those changes until after our workshop in Paris. We
will need to syncup to determine what's next in the meantime :)

Regards,

-- 
Hugo Beauzée-Luyssen
www.beauzee.fr