[x264-devel] Re: [patch] slightly faster quant

[Loren Merritt]

On Wed, 21 Sep 2005, Guillaume POIRIER wrote:
> On 9/21/05, Christian Heine <sennindemokrit at gmx.net> wrote:
>>
>> attached is a patch based on x264 rev 293 that replaces the MMX
>> optimized quant8x8 and quant4x4 with a new ones that run about 20%
>> faster.
>
> Your patch features a fair deal of cosmetic changes. I'm sure that a
> cleaned up version would be a lot easier to review, hence they will
> make their way to the svn repository faster.
>
> Nice work though!
>
> Guillaume

Just for the record: This is not MPlayer, and I have different patch 
standards. Yes, splitting a patch into functional and cosmetic parts would 
make it faster to review. But do not leave ugly code around just in order 
to reduce patch size.

--Loren Merritt

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html