[x264-devel] Re: [PATCH] set constraint_set[01]_flag when possible

[Loïc Le Loarer]

The Thursday 11 May 2006 16:24:26 -0700, Loren Merritt wrote:
> If you still think constraint_set[01]_flag should be set, then I'll set 
> them based on the value of sps->i_profile, not duplicate all the 
> parameter checks.

By the way, by checking that parameter checks are really duplicated, I
discover that the profile can be set to BASELINE while to shouldn't:
when weighted_bipred_idc (b_weighted_bipred is x264) is not 0.

I think the attached patch should be applied to correct this.

Thank you

-- 
Loïc
-------------- next part --------------
Index: encoder/set.c
===================================================================
--- encoder/set.c	(révision 522)
+++ encoder/set.c	(copie de travail)
@@ -82,7 +82,7 @@
         sps->i_profile_idc  = PROFILE_HIGH444;
     else if( param->analyse.b_transform_8x8 || param->i_cqm_preset != X264_CQM_FLAT )
         sps->i_profile_idc  = PROFILE_HIGH;
-    else if( param->b_cabac || param->i_bframe > 0 )
+    else if( param->b_cabac || param->i_bframe > 0 || param->analyse.b_weighted_bipred != 0)
         sps->i_profile_idc  = PROFILE_MAIN;
     else
         sps->i_profile_idc  = PROFILE_BASELINE;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20060512/31eed38d/attachment.pgp