[x264-devel] Re: [PATCH] set constraint_set[01]_flag when possible

[Loren Merritt]

On Fri, 12 May 2006, Loïc Le Loarer wrote:
> Le Thursday 11 May 2006 à 16:24:26 -0700, Loren Merritt a écrit:
>
>> I suppose you could argue that there is some value in setting
>> constraint_set1_flag for Baseline files, because there are decoders that
>> support Main but not all of Baseline.
>
> This is what I wanted to add. Because of this and because it is faster
> to do deblocking on the fly as it is possible in MAIN.

I don't buy speed as a reason. If I were implementing a decoder that 
supported both strategies of deblocking, I would select which one to use 
based on whether slicegroups or ASO were used in any given frame, not on 
the profile or constraint_set.

> By the way, by checking that parameter checks are really duplicated, I
> discover that the profile can be set to BASELINE while to shouldn't:
> when weighted_bipred_idc (b_weighted_bipred is x264) is not 0.

weighted_bipred applies only to B-frames. If there are B-frames, it's 
already not Baseline. However, I did fail to forbid weighted_bipred when 
not using B-frames. Fixed that instead.

--Loren Merritt