[x264-devel] Re: [PATCH] Altivec optimizations for quant4x4, quant4x4dc, quant8x8, sub8x8_dct8, sub16x16_dct8, pixel_sa8d_8x8, pixel_sa8d_16x16

[Guillaume POIRIER]

Hi,

Loren Merritt a écrit :
> On Sun, 10 Sep 2006, Guillaume POIRIER wrote:
>>
>> I attached 2 files today.
>> First and foremost, is the 12th revision of my patch. It features PMC 
>> support and an example of how to use them to benchmark in pixel.c 
>> (which should be stripped off if committed).
>> Nothing new except that.
>>
>> The 2nd patch is just the header file that adds the START/STOP_TIMER 
>> macros for PPC (it's also present in the whole patchset).
>> It's meant to be put in common/ppc.
>> I'm putting it aside to ease reviewing and because it's really a 
>> self-contained "patch".
>>
>> The question that probably needs to be asked now is: do you guys care 
>> to have
>> the START/STOP_TIMER also available on other arches, or just for PPC 
>> is fine?
>> Also note that I licensed this file under LGPL as it's essentially 
>> several pieces of code taken from FFmpeg and melted..
>
> I use START/STOP_TIMER frequently, I just #include it in any file I 
> want to benchmark. But if you want to put it permanently in x264, I'll 
> add the x86 version too.
>
> --Loren Merritt

Well IMHO, it makes everybody's life easier if the code is checked in
the repository, as that way, there's no need to do much to get started
with benchmarking.

What would be the best way to do this?
Should they all be put in timer.h or like you just did, have the PPC
part in common/ppc, and the C part in timer.h (and maybe the i386 part
in common/i386, same for amd64 part...).
I prefer the 2nd solution, but that's just me.

I'll try to come up with a patch that does this later. (+ I need to 
improve the comments on this file to explain how to set up PMCs on OSX 
or Linux)

Guillaume

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html