[x264-devel] Re: [PATCH] Altivec optimizations for quant4x4, quant4x4dc, quant8x8, sub8x8_dct8, sub16x16_dct8, pixel_sa8d_8x8, pixel_sa8d_16x16

[Guillaume POIRIER]

Hi

Guillaume POIRIER a écrit :

> Loren Merritt a écrit :
>> On Sun, 10 Sep 2006, Guillaume POIRIER wrote:

[..]

>> I use START/STOP_TIMER frequently, I just #include it in any file I 
>> want to benchmark. But if you want to put it permanently in x264, I'll 
>> add the x86 version too.
>>
>> --Loren Merritt
> 
> Well IMHO, it makes everybody's life easier if the code is checked in
> the repository, as that way, there's no need to do much to get started
> with benchmarking.
> 
> What would be the best way to do this?
> Should they all be put in timer.h or like you just did, have the PPC
> part in common/ppc, and the C part in timer.h (and maybe the i386 part
> in common/i386, same for amd64 part...).
> I prefer the 2nd solution, but that's just me.
> 
> I'll try to come up with a patch that does this later. (+ I need to 
> improve the comments on this file to explain how to set up PMCs on OSX 
> or Linux)


Ok, here's in attachment an improved version of your patch (fix license 
to LGPL for PPC part, and improved comments.

I didn't split the timer routines in separate directories, as after 
thinking about it again, it's a bit overkill.

Regards,

Guillaume
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264_timer.1.diff
Type: text/x-patch
Size: 6937 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/x264-devel/attachments/20060929/dfe003fe/attachment.bin