[x264-devel] Re: psp specific code?

[Loren Merritt]

On Thu, 12 Apr 2007, Paul Canavan wrote:

> A while ago I hacked a version of mencoder + x264 to produce files which
> will play on the PSP (available for download if you search ps2dev.org). This
> was based on already publicly available diffs so I didn't actually do much,
> just put stuff in the right place. Anyway...
> [...]
> Here's what I'd like to do:
> add a setPSP(int onOff) method, and wrap the psp specific code in if's. From
> what I can see, this would result in 3 int comparissons per frame for
> non-psp users. If this is too much, I could go further by wrapping the code
> in #ifdef's (though I always feel that they make code less readable) and
> adding a build target.

The standard way to add options is a field in x264_param_t.

But before you continue, is such a patch even needed anymore? iirc recent 
PSP firmwares don't have gratuitous format restrictions. I won't accept a 
workaround for something that Sony has already fixed.
And even aside from that, did PSP compatibility require any changes to 
the video stream, or only to the MP4 muxing? If it's just muxing, then 
having support in x264 won't help, because x264 doesn't do audio, so 
you'll have to remux anyway.

--Loren Merritt

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html