[x264-devel] Re: [patch] minor code cleanup and fix for x264.c

[Limin Wang]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


* Loren Merritt <lorenm at u.washington.edu> [2007-01-15 00:07:58 -0700]:
> i_frame_total == 0 means unkown, i.e. piped input or some muxer that 
> doesn't store the movie length. I suppose using INT_MAX for that instead 
> would slightly reduce the code size.

We can mark frame total count is zero without issue. For in case i_frame_total
is 0, the code execution will never enter encode "for" loop. I prefer to
checking i_frame_total before encode, if i_frame_total == 0, report error and
return directly.

> It's not codified anywhere. Yes, I can base one on xvid's style guide.

That's great, hope it'll out soon.

> 
> Agreed. That's leftover from when Fenrir was the maintainer, and I just
> never bothered to change it. Plus, while I make no attempt to keep the API 
> constant, I also don't change it without a functional reason.

So pity, at least, if the old didn't conform to the code style, it's better
to change it.

Thanks,
Limin
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQEVAwUBRateY0ztbf7dKiuoAQI1NQf8DCtwGDiA4Le4UAmVK2hK/0JD/7DHFlHs
2+LwxgiaOgayEFShAZwoeW4+XBBsdCFYTpfayC+mi01WzCbLfI5mXRhcMWZ1zrYm
+ypihayQj1HpOsJTZiNScZiaykzFfPNHxgqDvFbuZzRbXpSPWtZAOyWu/BIqLzjW
49eHr6In/cfefplVMKHw821nF8AqfCjA3H1BdlTkYv15sF21G2PzKpG5x0bxVz7+
kvwU1psrcLuKVkfquIQyXf0MBdcw1VRYIV0NWVOvBNvfDfH1/eF4Uq7akIiU7R+X
pG/VTCeYVNGqufmKYalnsZZnKYV0gawr3kua+M0GrDHJZf0TQCgsRQ==
=v311
-----END PGP SIGNATURE-----

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html