[x264-devel] Re: turn off skip modes?

[Loren Merritt]

On Thu, 22 Mar 2007, Axel Gunter wrote:
> Loren Merritt wrote:
>> On Wed, 21 Mar 2007, Axel Gunter wrote:
>> 
>>> Can I turn OFF skip modes while encoding 264 bitstreams using x264? If so, 
>>> how?
>> 
>> Why?
>> 
>> --direct=none completely disables skips in B-frames
>> --no-fast-pskip doesn't completely disable skips in P-frames, but it 
>> encodes macroblocks first as some other mode and then converts them to skip 
>> only if the original mode turns out to be identical to skip.
>
> Just wanted to evaluate the benefit of using skips or non-skip modes. So I 
> cant really turn off P-skip mode?

Apply this patch in addition to those options.

--Loren Merritt
-------------- next part --------------
Index: encoder/macroblock.c
===================================================================
--- encoder/macroblock.c	(revision 634)
+++ encoder/macroblock.c	(working copy)
@@ -628,6 +628,7 @@
     /* store cbp */
     h->mb.cbp[h->mb.i_mb_xy] = (i_cbp_dc << 8) | (h->mb.i_cbp_chroma << 4) | h->mb.i_cbp_luma;
 
+#if 0
     /* Check for P_SKIP
      * XXX: in the me perhaps we should take x264_mb_predict_mv_pskip into account
      *      (if multiple mv give same result)*/
@@ -649,6 +650,7 @@
             h->mb.i_type = B_SKIP;
         }
     }
+#endif
 }
 
 /*****************************************************************************