[x264-devel] Re: [patch] split slice nal unit when it exceeds size x

[Tom Harper]

Hi Alex,

re:
At 05:42 PM 5/2/2007, Alex Izvorski wrote:
>Could you modify the patch to do a fixed number of slices of the same
>number of mb's/rows of mb's, as well as what it does now?

It would be pretty easy to add a separate parameter to specify the type
of NAL size constraint- so sure.


>Also, could you make x264_slice_write() write only one slice at a time?
>Single calls would have to be replaced with something along the lines of
>while (! done) { x264_slice_write() } loop.  Alternately, just move the
>body of that routine into x264_slices_write().  I know this is splitting
>hairs but it is weird that both x264_slices_write and x264_slice_write
>do in fact write multiple slices right now ;)  The old slice code had
>x264_slice_write do just one slice at a time, and x264_slices_write do
>an entire frame.

Probably they should just be merged-I have an (untested) feeling that
h->out.i_frame_size = i_frame_size is not correct in the multithreaded
case- I'll look into this and get back to you.

Tom

-- 
This is the x264-devel mailing-list
To unsubscribe, go to: http://developers.videolan.org/lists.html