[x264-devel] NAL slice support patch added?

Loren Merritt lorenm at u.washington.edu
Fri Oct 26 11:13:33 CEST 2007


On Thu, 25 Oct 2007, Mojtaba Hosseini wrote:

> 2) I'm still not sure about compute/print stats in frame_end()
> function of encoder.c (these 2 lines):
>    h->stat.i_slice_count[h->sh.i_type]++;
>    h->stat.i_slice_size[h->sh.i_type] += h->out.i_frame_size +
>                                          NALU_OVERHEAD;
> This doesn't seem right. Should I be changing this to be updated for
> all slices in a frame? If so, I can move them to slice_write()
> function of encoder.c.

Those variables really count frames, not slices. Only NALU_OVERHEAD should 
be multiplied.

--Loren Merritt



More information about the x264-devel mailing list