[x264-devel] fix for MSVC

[Sean McGovern]

Is someone ready to do this? I'm not sure what the big issue is about
whitespace. How often does this file change?

-- Sean

-----Original Message-----
From: x264-devel-bounces at videolan.org
[mailto:x264-devel-bounces at videolan.org] On Behalf Of Loren Merritt
Sent: April 2, 2008 6:58 AM
To: Mailing list for x264 developers
Subject: Re: [x264-devel] fix for MSVC

On Mon, 31 Mar 2008, David Lariviere wrote:

> --- a/build/win32/libx264.vcproj
> +++ b/build/win32/libx264.vcproj
> @@ -843,7 +843,7 @@
>                 </FileConfiguration>
>         </File>
>         <File
> -               RelativePath="..\..\common\predict.c">
> +               RelativePath="..\..\common\x86\predict-c.c">
>                 <FileConfiguration
>                         Name="Release|Win32">
>                         <Tool
> @@ -877,7 +877,7 @@
>                 </FileConfiguration>
>         </File>
>         <File
> -               RelativePath="..\..\common\x86\predict-c.c">
> +               RelativePath="..\..\common\predict.c">
>                 <FileConfiguration
>                         Name="Release|Win32">
>                         <Tool

Cosmetics. If msvc insists on adding whitespace and reordering statements,
then undo that before submitting the patch. Or you could just write the
project file using a text editor; probably easier that way.

> --- a/common/osdep.h
> +++ b/common/osdep.h
> @@ -31,6 +31,17 @@
>  #include <inttypes.h>
>  #endif
>
> +//fixes logf bug in MSVC's math.h
> +//see 
> +http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?
> +FeedbackID=98751 //note this will only work if math.h is included 
> +after osdep.h #ifdef _MSC_VER #if !defined (_M_IA64) && !defined 
> +(_M_AMD64) #undef logf
> +#define logf(x)     ((float)log((double)(x)))
> +#endif    // !defined (_M_IA64) && !defined (_M_AMD64)
> +#endif

According to that url, not only is it a bug in msvc, it was fixed 2 years
ago. So I won't accept a workaround.

P.S. don't top-post. If I dropped all support for anything related to MS,
would that make the top-posters go away?

--Loren Merritt
_______________________________________________
x264-devel mailing list
x264-devel at videolan.org
http://mailman.videolan.org/listinfo/x264-devel