[x264-devel] [PATCH] fix more illegal identifiers

Måns Rullgård mans at mansr.com
Thu Apr 24 21:21:57 CEST 2008


Diego Biurrun <diego at biurrun.de> writes:

> OK, here is the next patch to do $subject.
>
> Diego
>
> diff --git a/gtk/x264_gtk.c b/gtk/x264_gtk.c
> index bf4d7c6..8f95c24 100644
> --- a/gtk/x264_gtk.c
> +++ b/gtk/x264_gtk.c
> @@ -330,7 +330,7 @@ x264_gtk_free (X264_Gtk *x264_gtk)
>  /* Callbacks */
>  
>  static void
> -_dialog_run (GtkDialog       *dialog __UNUSED__,
> +_dialog_run (GtkDialog       *dialog UNUSED,

_dialog_run and similar names are also bad, since all identifiers
beginning with _ are reserved at the file scope.  _[a-z] is allowed
for local variables and struct/union members.

-- 
Måns Rullgård
mans at mansr.com


More information about the x264-devel mailing list