[x264-devel] [PATCH] fix more illegal identifiers

[Guillaume POIRIER]

Hello,

On Thu, Apr 24, 2008 at 9:21 PM, Måns Rullgård <mans at mansr.com> wrote:
> Diego Biurrun <diego at biurrun.de> writes:
>
>  > OK, here is the next patch to do $subject.
>  >
>  > Diego
>  >
>  > diff --git a/gtk/x264_gtk.c b/gtk/x264_gtk.c
>  > index bf4d7c6..8f95c24 100644
>  > --- a/gtk/x264_gtk.c
>  > +++ b/gtk/x264_gtk.c
>  > @@ -330,7 +330,7 @@ x264_gtk_free (X264_Gtk *x264_gtk)
>  >  /* Callbacks */
>  >
>  >  static void
>  > -_dialog_run (GtkDialog       *dialog __UNUSED__,
>  > +_dialog_run (GtkDialog       *dialog UNUSED,
>
>  _dialog_run and similar names are also bad, since all identifiers
>  beginning with _ are reserved at the file scope.  _[a-z] is allowed
>  for local variables and struct/union members.

Yep, I noticed that too, I just figured that Diego had a separate
patch for that issue.

Cheers,

Guillaume
-- 
I don't measure a man's success by how high he climbs but how high he
bounces when he hits bottom.
 -- George S. Patton