[x264-devel] [PATCH] fix more illegal identifiers

Guillaume POIRIER poirierg at gmail.com
Thu Apr 24 21:23:17 CEST 2008


Hello Diego,

2008/4/24 Diego Biurrun <diego at biurrun.de>:
> OK, here is the next patch to do $subject.

Thanks for the patch.

I prefer the solution fix as in the attached patch. this avoids
defining over and over UNUSED and re-uses the definition in
common/osdep.h

I believe it's better to do it that way, simply because the previous
code unconditionally used "unused" attribute no matter if the compiler
supported it or not.

Guillaume
-- 
I don't measure a man's success by how high he climbs but how high he
bounces when he hits bottom.
 -- George S. Patton
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: illegal_identifiers3.diff
Url: http://mailman.videolan.org/pipermail/x264-devel/attachments/20080424/d490b864/attachment.txt 


More information about the x264-devel mailing list